Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Plutus deps to 1.11 #3680

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Conversation

bezirg
Copy link
Collaborator

@bezirg bezirg commented Aug 25, 2023

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@bezirg bezirg requested review from a team as code owners August 25, 2023 16:51
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever bounds in a cabal file are changed the patch version of the package needs to be increased, otherwise the package will not get released next time we'll be going through a release process. So, could you please bump the last number in versions for these packages:

  • cardano-ledger-alonzo-test
  • cardano-ledger-binary

@bezirg bezirg force-pushed the bezirg/plutus-1.11.0.0 branch 2 times, most recently from 9951c05 to e807f6f Compare September 4, 2023 12:40
@lehins lehins force-pushed the bezirg/plutus-1.11.0.0 branch from e807f6f to 826fe84 Compare September 5, 2023 16:21
@lehins lehins force-pushed the bezirg/plutus-1.11.0.0 branch from 826fe84 to 9141820 Compare September 5, 2023 20:06
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break some of the plutus functionality in Conway, but the breakage only affects Conway and PlutusV3, so this is totally fine

@lehins lehins enabled auto-merge September 5, 2023 20:08
@lehins lehins merged commit c4ca6fc into IntersectMBO:master Sep 5, 2023
9 of 162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants